Spatial Indexing by ryanstocks00 · Pull Request #3 · Trailblaze-Software/laspp

ryanstocks00 · 2025-11-07T10:57:39Z

No description provided.

codecov · 2025-11-07T10:59:58Z

Codecov Report

❌ Patch coverage is 95.27105% with 82 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/spatial_index.hpp	85.76%	41 Missing ⚠️
src/las_header.hpp	79.06%	9 Missing ⚠️
src/las_reader.hpp	92.85%	9 Missing ⚠️
src/vlr.hpp	60.00%	8 Missing ⚠️
src/utilities/printing.hpp	83.33%	7 Missing ⚠️
src/laz/stream.hpp	80.00%	5 Missing ⚠️
src/laz/tests/test_laszip_interop.cpp	98.76%	1 Missing ⚠️
src/tests/test_writer_copy_from_reader.cpp	99.61%	1 Missing ⚠️
src/utilities/thread_pool.hpp	96.96%	1 Missing ⚠️

Flag	Coverage Δ
unittests	`93.42% <95.27%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/example_custom_las_point.hpp	`100.00% <ø> (ø)`
src/las_point.hpp	`44.25% <ø> (ø)`
src/las_writer.hpp	`95.68% <100.00%> (ø)`
src/laz/bytes14_encoder.hpp	`100.00% <100.00%> (ø)`
src/laz/chunktable.hpp	`100.00% <ø> (ø)`
src/laz/layered_stream.hpp	`100.00% <ø> (ø)`
src/laz/laz_reader.hpp	`87.50% <ø> (ø)`
src/laz/laz_writer.hpp	`90.47% <ø> (ø)`
src/laz/symbol_encoder.hpp	`100.00% <100.00%> (ø)`
src/laz/tests/test_bytes14_encoder.cpp	`100.00% <100.00%> (ø)`
... and 16 more

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

Adds support for reading/writing LAStools (.lax / EVLR) quadtree spatial indexes and integrates it into copy/conversion workflows, while also refactoring parallelism utilities, printing helpers, and build configuration.

Changes:

Introduce QuadtreeSpatialIndex and add LASReader/LASWriter support for detecting, copying, and optionally generating LAStools spatial index EVLRs.
Replace <execution>-based parallel loops with an internal thread-pool approach, including a new parallel reduction helper.
Add printing helpers (indentation + limited map printing), new tests, and adjust CMake/CI to improve cross-compiler compatibility.

Reviewed changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
src/vlr.hpp	Improves VLR/EVLR printing and adds helpers to identify LAStools spatial index records.
src/utilities/thread_pool.hpp	Adds `parallel_for_reduction` and related includes/utilities.
src/utilities/tests/test_printing.cpp	Adds tests for new printing helpers.
src/utilities/printing.hpp	Adds `Indented`/`LimitedMap` wrappers and `std::map` streaming support.
src/utilities/assert.hpp	Adjusts seek macro warnings and headers/includes.
src/tests/test_writer_copy_from_reader.cpp	Adds coverage for writer copy-from-reader and spatial index behavior.
src/tests/test_transform_accessors.cpp	Adds tests for new non-const Transform accessors.
src/tests/test_reader_constructors.cpp	Adds tests for reader constructors and `.lax` discovery/precedence behavior.
src/tests/test_reader.cpp	Adds tests for interval→chunk mapping and reading non-contiguous chunk lists.
src/tests/test_bound2d.cpp	Adds tests for new `Bound2D`.
src/spatial_index.hpp	New LAStools spatial index implementation (read/write + cell computations).
src/laz/tests/test_spatial_index.cpp	Adds LAZ-side tests for spatial index functionality.
src/laz/tests/test_laszip_interop.cpp	Updates Transform usage to new API.
src/laz/stream.hpp	Tightens bounds-checked reads and seek behavior for pointer-backed streams.
src/laz/laz_writer.hpp	Adds handling for (unsupported) LAZ item type `Byte14` and removes `<execution>`.
src/laz/laz_reader.hpp	Adds handling for (unsupported) LAZ item type `Byte14`.
src/laz/layered_stream.hpp	Formatting/initialization tweak for the empty-layer buffer.
src/laz/chunktable.hpp	Fixes `#pragma pack(pop)` placement.
src/las_writer.hpp	Adds copy-from-reader and spatial index writing; refactors parallel copy/stats to thread-pool utilities.
src/las_reader.hpp	Adds spatial index detection (EVLR + `.lax`), stream-parallel LAZ chunk reads, and interval/chunk helpers.
src/las_point.hpp	Minor include cleanup.
src/las_header.hpp	Introduces `Bound2D`, adds Transform accessors, and exposes points-by-return helper.
src/example_custom_las_point.hpp	Adds missing standard includes for example point type.
cmake/SetupLazperf.cmake	Makes warning suppression flags compiler-specific (GCC vs Clang).
cmake/SetupLaszip.cmake	Makes warning suppression flags compiler-specific (GCC vs Clang).
apps/validate_spatial_index.cpp	New CLI tool to validate spatial index correctness vs points.
apps/las2las++.cpp	Updates CLI to use copy-from-reader and optionally add spatial index.
apps/inspect_vlrs.cpp	New CLI tool to inspect VLR/EVLRs and spatial index details.
apps/create_test_file.cpp	Updates Transform usage to new API.
apps/CMakeLists.txt	Builds/installs new CLI tools and adds MSVC `/bigobj` handling.
CMakeLists.txt	Scopes strict flags/aggressive opts to top-level project; MSVC `/bigobj` for tests.
.github/workflows/cmake-multi-platform.yml	Removes Clang OpenMP install step.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

codacy-production · 2026-04-03T23:04:56Z

Up to standards ✅

🟢 Issues 34 medium

Results:
34 new issues

Category Results

BestPractice 12 medium

ErrorProne 2 medium

Complexity 20 medium

View in Codacy

🟢 Metrics 308 complexity · 107 duplication

Metric Results

Complexity 308

Duplication 107

View in Codacy

_{TIP This summary will be updated as you push new changes. Give us feedback}

Copilot

Pull request overview

Copilot reviewed 35 out of 35 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 35 out of 35 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 35 out of 35 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 35 out of 35 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 35 out of 35 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Initial spatial index implementation

40deaa9

ryanstocks00 added 18 commits November 7, 2025 22:13

Added non const offsets method

23b1198

Fixing bugs with point format 14 boundary updating

b731146

Reading subset of chunks from spatial index

ffb9185

Write with chunks

78f13d0

Bit of cleanup

c7bc94a

Merge branch 'main' into spatial_index

6540489

MIT License

f5d111a

Remove redundant casts

5792e80

Minor fixes to spatial index test

6dfb768

Make constructor explicit

a5266ed

Fix redundant cast warnings

c5caf70

Remove tbb dependency

70be227

Update clang warnings

f86196c

Fix unaligned reads

cbe12bf

Add parallel reduction

3f7a79c

Move pragma pack

69a205a

Minor warning fixes

a97a617

Remove unused parallel headers

ea72478

ryanstocks00 commented Mar 7, 2026

View reviewed changes

Comment thread src/las_reader.hpp Outdated

Comment thread src/las_reader.hpp Outdated

ryanstocks00 commented Mar 8, 2026

View reviewed changes

Comment thread src/spatial_index.hpp

Clean up includes

cfe0636

ryanstocks00 force-pushed the spatial_index branch from 83e0223 to cfe0636 Compare March 8, 2026 10:10

ryanstocks00 added 2 commits March 8, 2026 21:26

Parallel chunk subset read

8525dad

Correct packing

640b377

ryanstocks00 requested a review from Copilot March 8, 2026 10:39

Copilot started reviewing on behalf of ryanstocks00 March 8, 2026 10:40 View session

Copilot AI reviewed Mar 8, 2026

View reviewed changes

Move project call earlier

f7e7b59

ryanstocks00 and others added 5 commits March 8, 2026 22:15

Update src/las_writer.hpp

e067be2

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/las_writer.hpp

65a32a2

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/utilities/printing.hpp

44be0fe

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Cleanup import orders

de0c2f5

Better dealing with null terminations

f4f1980

ryanstocks00 added 2 commits April 4, 2026 17:28

Fixing span ref passing to stream layers

324865b

Streaming point copy without spatial index

f287385

ryanstocks00 requested a review from Copilot April 4, 2026 07:35

Copilot started reviewing on behalf of ryanstocks00 April 4, 2026 07:36 View session

Copilot AI reviewed Apr 4, 2026

View reviewed changes

Comment thread src/utilities/assert.hpp

Comment thread src/utilities/thread_pool.hpp

Comment thread src/utilities/printing.hpp

Comment thread src/utilities/printing.hpp

Comment thread src/spatial_index.hpp

Comment thread src/las_writer.hpp Outdated

ryanstocks00 added 2 commits April 16, 2026 23:16

Move int32_to_double

b673d07

Cleanup asserts and printing

1386e94

ryanstocks00 requested a review from Copilot April 17, 2026 04:16

Copilot started reviewing on behalf of ryanstocks00 April 17, 2026 04:17 View session

Copilot AI reviewed Apr 17, 2026

View reviewed changes

Minor cleanup and laszip spatial index test

c486246

ryanstocks00 requested a review from Copilot April 20, 2026 13:22

Copilot started reviewing on behalf of ryanstocks00 April 20, 2026 13:23 View session

Minor fixes

72f5728

Copilot AI reviewed Apr 20, 2026

View reviewed changes

Comment thread apps/validate_spatial_index.cpp

Comment thread CMakeLists.txt

Comment thread src/las_writer.hpp

Comment thread apps/validate_spatial_index.cpp

Minor fixes

74a87e4

ryanstocks00 requested a review from Copilot April 20, 2026 13:38

Copilot started reviewing on behalf of ryanstocks00 April 20, 2026 13:39 View session

Copilot AI reviewed Apr 20, 2026

View reviewed changes

Comment thread src/spatial_index.hpp

Comment thread src/spatial_index.hpp

Comment thread src/spatial_index.hpp Outdated

Comment thread src/las_reader.hpp

Comment thread src/las_reader.hpp

Comment thread src/laz/stream.hpp Outdated

Clean up error handling

a9c92bb

ryanstocks00 requested a review from Copilot April 21, 2026 11:59

Copilot started reviewing on behalf of ryanstocks00 April 21, 2026 12:00 View session

Copilot AI reviewed Apr 21, 2026

View reviewed changes

ryanstocks00 merged commit c3a244d into main Apr 21, 2026
18 checks passed

Conversation

ryanstocks00 commented Nov 7, 2025

Uh oh!

codecov Bot commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codacy-production Bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Up to standards ✅

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

codecov Bot commented Nov 7, 2025 •

edited

Loading

codacy-production Bot commented Apr 3, 2026 •

edited

Loading